Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimum and maximum curtain state #227

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Fix minimum and maximum curtain state #227

merged 3 commits into from
Jan 28, 2022

Conversation

dnicolson
Copy link
Collaborator

♻️ Current situation

The curtain set_min and set_max options do not appear to work correctly.

💡 Proposed solution

It looks like the setMinMax call needs to occur after the previous line otherwise the CurrentPosition value would always be redefined. Fixes #123.

➕ Additional Information

The setMinMax in the constructor is removed as the CurrentPosition value is redefined later in the method. The !this.setNewTarget conditional was also removed because it would always evaluate to true.

@donavanbecker donavanbecker changed the base branch from latest to beta January 28, 2022 19:48
@donavanbecker
Copy link
Collaborator

@dnicolson Thanks! I will merge this into beta so we can get a few people to test before we publish a new version

@donavanbecker donavanbecker merged commit 0fdfb39 into OpenWonderLabs:beta Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: curtains not updating
2 participants