Fix minimum and maximum curtain state #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
The curtain
set_min
andset_max
options do not appear to work correctly.💡 Proposed solution
It looks like the
setMinMax
call needs to occur after the previous line otherwise theCurrentPosition
value would always be redefined. Fixes #123.➕ Additional Information
The
setMinMax
in the constructor is removed as theCurrentPosition
value is redefined later in the method. The!this.setNewTarget
conditional was also removed because it would always evaluate to true.