Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patch Node.js version requirement #843

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Remove patch Node.js version requirement #843

merged 1 commit into from
Oct 18, 2023

Conversation

dnicolson
Copy link
Collaborator

♻️ Current situation

Updating the plug-in often shows warnings in Homebridge Config X and also in the logs when the minimum Node.js patch version increases.

💡 Proposed solution

Use only the major version, similar to this:
https://github.com/homebridge/homebridge-config-ui-x/pull/1570/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R31

Fixes #837.

@donavanbecker
Copy link
Collaborator

I would prefer to update the node version so users get warning to get the latest as there are bug fixes in the latest version.

@donavanbecker
Copy link
Collaborator

And since it is just a warning it doesn't effect anything.

@dnicolson
Copy link
Collaborator Author

The warning can be confusing, even with the hb-service update-node command upgrading Node.js can unnecessarily break other packages.

Updating the engines to the latest versions of Node.js is also an uncommon pattern. According to npm, it's supposed to represent the "version of node that your stuff works on".

For comparison, Homebridge supports Node.js >=10.17.0.

@donavanbecker
Copy link
Collaborator

Then I would at least do minor updates. The reason I like the patches is because of bug fixes

@dnicolson
Copy link
Collaborator Author

Then I would at least do minor updates. The reason I like the patches is because of bug fixes

That still doesn't reflect the intent of engines. Do these bug fixes affect the compatibility of the plug-in?

Updating minor versions can also introduce unrelated issues, the issue nodejs/node#46221 came up again today that was introduced in Node.js 18.3.0.

@donavanbecker donavanbecker merged commit bbdd1b2 into OpenWonderLabs:latest Oct 18, 2023
5 of 8 checks passed
@donavanbecker
Copy link
Collaborator

@dnicolson dnicolson mentioned this pull request Oct 18, 2023
banboobee pushed a commit to banboobee/homebridge-switchbot that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Update minimum Node.js versions only for breaking changes
2 participants