Replace abi.encodeWithSelector by abi.encodeCall

[wiasliaw]

🧐 Motivation
Since 0.8.11, abi.encodeCall provide type-safe encode utility comparing with abi.encodeWithSelector.

📝 Details
Example below and detail are from DevTools Summit | Topics in Solidity - Harikrishnan Mulackal.

abi.encodeWithSelector can use with interface.<function>.selector to prevent typo error, but it doesn't provide type checking.

interface miniERC20 {
  function transfer(address to, uint256 value) external;
}

// works successfully
function transferData(uint256 to, uint256 value)
    public
    pure
    returns (bytes memory)
{
    return abi.encodeWithSelector(miniERC20.transfer.selector, to, value);
}

abi.encodeCall provide type checking during compile time.

function transferData(uint256 to, uint256 value)
    public
    pure
    returns (bytes memory)
{
    return abi.encodeCall(miniERC20.transfer, (to, value));
}

result

error[5407]: TypeError: Cannot implicitly convert component at position 0 from "uint256" to "address".

[frangio]

We should definitely do this, but it requires bumping the Solidity pragma and this is a breaking change, so it should be done in our next major.

[ashwinYardi]

Hey guys! If this is gonna be the part of v5.0 milestone , I would love to draft a PR for this :)

[0xad1onchain]

To implement this change, the pragma upgrade at min must be >= 0.8.13, since the original implementation was bugged
Ref to blogpost describing bug

[frangio]

@balajipachai Do you want to help with this issue?

[balajipachai]

@frangio Sure

[balajipachai]

@frangio It is done, could you please direct me to some other open issues with deadlines, I will get those done well within the deadline.