Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace abi.encodeWithSelector & abi.encodeWithSignature with abi.encodeCall #4293

Conversation

balajipachai
Copy link
Contributor

  • adds changeset
  • updates contracts: MultiCallTest, ReentrancyMock, UUPSLegacy, ERC4626, SafeERC20, SignatureChecker, ERC165Checker
  • updates utils ShortStrings.t.sol

Fixes #3693

  • All occurrences of abi.encodeWithSelector & abi.encodeWithSignature are replaced by abi.encodeCall

PR Checklist

  1. All tests are passing
  2. npm run slither returned INFO:Slither:. analyzed (429 contracts with 46 detectors), 0 result(s) found
  3. No linting issues
  4. All contracts are compiling
  • [All Passing] Tests
  • [No Changes] Documentation
  • [Added] Changeset entry (run npx changeset add)

…abi.encodeCall

* adds changeset
* updates contracts: MultiCallTest, ReentrancyMock, UUPSLegacy, ERC4626, SafeERC20, SignatureChecker, ERC165Checker
* updates utils ShortStrings.t.sol
@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

🦋 Changeset detected

Latest commit: c2fbbde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/big-plums-cover.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the changeset, otherwize looks good.

Amxx
Amxx previously approved these changes Jun 1, 2023
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amxx Amxx requested a review from frangio June 1, 2023 07:54
@balajipachai
Copy link
Contributor Author

@Amxx @frangio Could you guys guide me to some another issue?, please, I would be more than happy to help

test/utils/ShortStrings.t.sol Outdated Show resolved Hide resolved
test/utils/ShortStrings.t.sol Outdated Show resolved Hide resolved
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

This was referenced Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace abi.encodeWithSelector by abi.encodeCall
3 participants