Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TransparentUpgradeableProxy admin immutable #4354

Conversation

ernestognw
Copy link
Member

@ernestognw ernestognw commented Jun 15, 2023

Fixes #2638
Fixes LIB-805

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

🦋 Changeset detected

Latest commit: 57e6869

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ernestognw ernestognw changed the title Make TransparentUpgradeableProxy Make TransparentUpgradeableProxy admin immutable Jun 15, 2023
@ernestognw ernestognw requested review from frangio and Amxx and removed request for frangio June 15, 2023 18:58
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

@ernestognw ernestognw requested review from frangio and Amxx June 15, 2023 22:50
ernestognw and others added 2 commits June 16, 2023 10:30
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw ernestognw requested a review from Amxx June 16, 2023 16:32
This was referenced Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransparentUpgradeableProxy could be optimized by making admin immutable
3 participants