Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change access folder structure #4359

Merged
merged 8 commits into from
Jul 13, 2023

Conversation

RenanSouza2
Copy link
Contributor

Fixes #3583

Changes access golder structure

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2023

🦋 Changeset detected

Latest commit: 35402b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx Amxx added breaking change Changes that break backwards compatibility of the public API. idea labels Jun 16, 2023
@Amxx Amxx added this to the 5.0 milestone Jun 16, 2023
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @RenanSouza2, we still need to agree on this, but in the meantime I'd recommend taking a look to the docs preview, you can find them on the CI checks (Netlify), because there are a few things to address within this PR:

  • The navigation for the Access section will likely change to reflect those changes
  • There are some cross references to the access contracts across the documentation that we will need to make sure are not broken

.changeset/spicy-sheep-eat.md Outdated Show resolved Hide resolved
@RenanSouza2
Copy link
Contributor Author

RenanSouza2 commented Jun 17, 2023

  • There are some cross references to the access contracts across the documentation that we will need to make sure are not broken

About that, I am looking for broken links as so far the one I found was in the file releases-satability.adoc in [[major-releases]] section, the link is broken

update: In that file all but one github links are broken

@ernestognw ernestognw requested review from frangio and Amxx July 13, 2023 03:12
Amxx
Amxx previously approved these changes Jul 13, 2023
@frangio
Copy link
Contributor

frangio commented Jul 13, 2023

I don't think this change breaks any links in the docs in particular.

This was referenced Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that break backwards compatibility of the public API. idea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grouping the extension access control contracts into one extensions/ folder
4 participants