Skip Slang parser for solc versions that it does not support #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Interesting. Looks good to me.
This provides a new perspective on my comment here: #1060 (comment)
It's not just because of unsupported platforms but also unsupported compiler versions that we can't assume Slang to be present.
Intuitively this doesn't sound good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1074
Slang supports specific Solidity versions, currently up to
0.8.26. If the user's project is using0.8.27, this causes errorUnsupported language version '0.8.27'As a longer-term solution, we may want to try falling back to the most recent version supported by Slang for parsing, but we should evaluate the implications of that further.
For now, we just skip the Slang code path (i.e. we won't remove non-struct NatSpec) for solc versions not supported by Slang.