praeclarum#284 - reverted the signature change of SQLiteConnection fo…

…r backward compatibility
Opti-Q · Apr 18, 2020 · 9ffda75 · 9ffda75
1 parent 43a5258
commit 9ffda75
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 19 deletions.
diff --git a/src/SQLite.cs b/src/SQLite.cs
@@ -253,16 +253,11 @@ static SQLiteConnection ()
 		/// If you use DateTimeOffset properties, it will be always stored as ticks regardingless
 		/// the storeDateTimeAsTicks parameter.
 		/// </param>
-		/// <param name="storeGuidsAsBlobs">
-		/// Specifies whether to store Guid properties as BLOBS (true) or strings (false).
-		/// Storing guids as blobs has multiple benefits: Faster indexing time, smaller footprint
-		/// and most importantly: compatibility with Microsoft.Data.Sqlite
-		/// </param>
-		public SQLiteConnection (string databasePath, bool storeDateTimeAsTicks = true, bool storeGuidsAsBlobs = false)
-			: this (new SQLiteConnectionString (databasePath, SQLiteOpenFlags.ReadWrite | SQLiteOpenFlags.Create, storeDateTimeAsTicks, storeGuidsAsBlobs:storeGuidsAsBlobs))
+		public SQLiteConnection(string databasePath, bool storeDateTimeAsTicks = true)
+			: this(new SQLiteConnectionString(databasePath, SQLiteOpenFlags.ReadWrite | SQLiteOpenFlags.Create, storeDateTimeAsTicks))
 		{
 		}
-
+		
 		/// <summary>
 		/// Constructs a new SQLiteConnection and opens a SQLite database specified by databasePath.
 		/// </summary>
@@ -280,13 +275,8 @@ public SQLiteConnection (string databasePath, bool storeDateTimeAsTicks = true,
 		/// If you use DateTimeOffset properties, it will be always stored as ticks regardingless
 		/// the storeDateTimeAsTicks parameter.
 		/// </param>
-		/// <param name="storeGuidsAsBlobs">
-		/// Specifies whether to store Guid properties as BLOBS (true) or strings (false).
-		/// Storing guids as blobs has multiple benefits: Faster indexing time, smaller footprint
-		/// and most importantly: compatibility with Microsoft.Data.Sqlite
-		/// </param>
-		public SQLiteConnection (string databasePath, SQLiteOpenFlags openFlags, bool storeDateTimeAsTicks = true, bool storeGuidsAsBlobs = false)
-			: this (new SQLiteConnectionString (databasePath, openFlags, storeDateTimeAsTicks, storeGuidsAsBlobs: storeGuidsAsBlobs))
+		public SQLiteConnection (string databasePath, SQLiteOpenFlags openFlags, bool storeDateTimeAsTicks = true)
+			: this (new SQLiteConnectionString (databasePath, openFlags, storeDateTimeAsTicks))
 		{
 		}
 

diff --git a/tests/GuidsAsBlobsTest.cs b/tests/GuidsAsBlobsTest.cs
@@ -34,8 +34,8 @@ public override string ToString()
 
 		public class TestDb : SQLiteConnection
 		{
-			public TestDb(String path)
-				: base(path, storeGuidsAsBlobs: true)
+			public TestDb(string path)
+				: base(new SQLiteConnectionString (path, storeGuidsAsBlobs:true))
 			{
 				CreateTable<TestObj>();
 			}
@@ -160,7 +160,7 @@ public async Task ShouldQueryGuidCorrectlyUsingLinqAsync()
 		[Test]
 		public void AutoGuid_HasGuid()
 		{
-			var db = new SQLiteConnection(TestPath.GetTempFileName(), storeGuidsAsBlobs: true);
+			var db = new SQLiteConnection(new SQLiteConnectionString(TestPath.GetTempFileName(), storeGuidsAsBlobs: true));
 			db.CreateTable<TestObj>(CreateFlags.AutoIncPK);
 
 			var guid1 = new Guid("36473164-C9E4-4CDF-B266-A0B287C85623");
@@ -180,7 +180,7 @@ public void AutoGuid_HasGuid()
 		[Test]
 		public void AutoGuid_EmptyGuid()
 		{
-			var db = new SQLiteConnection(TestPath.GetTempFileName(), storeGuidsAsBlobs: true);
+			var db = new SQLiteConnection(new SQLiteConnectionString (TestPath.GetTempFileName(), storeGuidsAsBlobs: true));
 			db.CreateTable<TestObj>(CreateFlags.AutoIncPK);
 
 			var guid1 = new Guid("36473164-C9E4-4CDF-B266-A0B287C85623");