Splits XPath evaluation in parsing then eval. #3002
Merged
+128
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/accept |
|
🕗 /accept is running, please wait for completion. |
|
🔨 Auto rebase from
|
|
🕗 /accept is still running, please wait for completion. |
hurl-bot
force-pushed
the
split-xpath-evaluation-in-parse-then-eval
branch
from
29c9dd4
to
aed9add
Compare
|
✅ Pull request merged and closed by
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We split the xpath evaluation function into two functions: a
parsemethod for (&str-> HTML/Xml document) andeval_xpathmethod that takes an input document now (vs a&str).This is preliminary work to cache parsed object for XPath query.