Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pr to update MailKit, ideally replacing #8746 #8768

Open
wants to merge 6 commits into
base: 1.10.x
Choose a base branch
from

Conversation

AndreaPiovanelli
Copy link
Contributor

This should replace #8746 starting from the up-to-date 1.10.x branch.

@@ -116,7 +106,11 @@ public class SmtpMessageChannel : Component, ISmtpChannel, IDisposable {
mailMessage.ReplyTo.AddRange(ParseRecipients(emailMessage.ReplyTo));
}

_smtpClientField.Value.Send(mailMessage);
using (var smtpClient = CreateSmtpClient()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth having an overload which takes multiple emails to reuse the client, otherwise bulk-sending them will create as many connections.

@BenedekFarkas
Copy link
Member

BenedekFarkas commented Apr 4, 2024

Please merge the latest 1.10.x to fix the build error.

@BenedekFarkas
Copy link
Member

BenedekFarkas commented May 7, 2024

@AndreaPiovanelli @MatteoPiovanelli-Laser would you like to continue working on this or #8746?

@MatteoPiovanelli-Laser
Copy link
Contributor

I've rebased this one as well. At this point I'm just hoping either of the PRs passes github's checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants