[Typing] 为 Paddle 框架 API 添加类型提示（Type Hints）的项目总结。 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pfccblog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
16 tasks
sunzhongkai588
requested review from
SigureMo,
sunzhongkai588,
jzhang533 and
luotao1
SigureMo
reviewed
Sep 2, 2024
| - 粒度控制 | ||
| - 单元测试 | ||
|
|
||
| 所谓「粒度控制」是指，很难用统一的标注来划分哪些类型需要归类入 `_typing`，哪些则直接使用 Python 的基础类型进行组合。比如，`_typing` 中的 `IntSequence = Sequence[int]`，很多地方都会用到，但，具体到每个接口，也许直接标注 `Sequence[int]` 会更简单。 |
There was a problem hiding this comment.
这个要不提个 PR 都替换了吧，直接用 Sequence[int] 就行了，这个应该是直接从 paddlepaddle-stubs 搬过来的，paddlepaddle-stubs 早期用的是 IntSequence = tuple[int, ...] | list[int]，后来改成 IntSequence = Sequence[int] 也没删，但实际上没啥必要
There was a problem hiding this comment.
提了个 PR 删了 PaddlePaddle/Paddle#67929
SigureMo
reviewed
Sep 2, 2024
src/posts/type-hints-project.md
Outdated
| <div style="display: flex; justify-content: center"> | ||
| <figure style="width: 80%;"> | ||
| <img src="../images/type-hints-project/typing_module.png"/> | ||
| <figcaption>typing_module.pyi</figcaption> |
There was a problem hiding this comment.
这里使用 .pyi 还是 .png 是怎么确定的？
There was a problem hiding this comment.
.png ～ 这里写错了 ～
昨晚写的有点累，偷懒 figcaption 跟 src 用同一个名字了，其实用中文会更好 ... ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为 Paddle 框架 API 添加类型提示（Type Hints）的项目总结。
关联：PaddlePaddle/Paddle#63597
@sunzhongkai588 @SigureMo @luotao1
请评审 ～