Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word2007 Reader : Added support for Comments #2469

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Word2007 Reader : Added support for Comments #2469

merged 5 commits into from
Sep 14, 2023

Conversation

Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Sep 13, 2023

Description

Word2007 Reader : Added support for Comments

Superseeds #2161. Thanks @shaedrich.

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@Progi1984 Progi1984 added this to the 1.2.0 milestone Sep 13, 2023
@coveralls
Copy link

coveralls commented Sep 13, 2023

Coverage Status

coverage: 81.553% (+0.07%) from 81.484% when pulling 0ea59e7 on pr2161 into d94b00c on master.

@shaedrich
Copy link
Contributor

Awesome! Happy, that this is picked up! Looking forward to its release :)

@Progi1984 Progi1984 merged commit 8c23738 into master Sep 14, 2023
25 checks passed
@Progi1984 Progi1984 deleted the pr2161 branch September 14, 2023 07:29
@Progi1984
Copy link
Member Author

@shaedrich It's merged for the next 1.2.0 version.

@shaedrich
Copy link
Contributor

This is awesome. Thanks you for implementing it!

@Progi1984
Copy link
Member Author

Thanks for the PR. And sorry for the late implementation.

@shaedrich
Copy link
Contributor

Better late then never—no harm done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants