Added xml reader hyperlink support #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests and changelog are missing, so it can't be merge yet. |
added unit test and change log
|
@PowerKiKi Hello, this branch seems out of time with GreatHumorist:develop918_1, but there is just one line conflict, the code I have tested in local and it works, please help me resolve the conflict, thx. |
PowerKiKi
requested changes
Sep 21, 2017
| @@ -549,7 +549,9 @@ | |||
| <Data ss:Type="String">AE</Data> | |||
| </Cell> | |||
| <Cell ss:StyleID="ce5"/> | |||
| <Cell ss:StyleID="ce5"/> | |||
| <Cell ss:StyleID="ce5" ss:HRef="http://www.phpexcel.net/"> | |||
| <Data ss:Type="String">PHPExcel</Data> | |||
There was a problem hiding this comment.
Let's not use "PHPExel" anymore, but instead "http://www.example.com" and "My website" or something similar.
| protected function loadXEETestFile() | ||
| { | ||
| if (!$this->spreadsheetXEETest) { | ||
| $filename = __DIR__ . '/../../../samples/templates/Excel2003XMLTest.xml'; |
There was a problem hiding this comment.
because we chdir(__DIR__); in tests/bootstrap.php, you can simplify this line with:
$filename = '../samples/templates/Excel2003XMLTest.xml';|
|
||
| // Load into this instance | ||
| $reader = new Xml(); | ||
| $this->spreadsheetXEETest = $reader->loadIntoExisting($filename, new Spreadsheet()); |
There was a problem hiding this comment.
why not just $reader->load($filename) ?
|
@PowerKiKi updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
What does it change?
Add XML Reader hyperlink support so that we can use link for the cell.