Fixed #201 when no 'r' attribute in node c in xlsx's xml #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests and changelog are missing, so it can't be merge yet. |
PowerKiKi
added
the
reader/xlsx
|
@PowerKiKi what kind of test do I need? |
|
We need a PHPUnit tests that proves that the code still behave like before, and also support the new case of missing attribute. |
When describing a cell, the cell reference (r="A1") is optional. When not present, we should just increment the index of the last processed row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
What does it change?
Fixed #201 when no 'r' attribute in node c in xlsx's xml.