Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official TBB v2021.8.0 release #126

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

ahans
Copy link
Contributor

@ahans ahans commented Apr 5, 2023

The latest stable release seems to be working just fine?

I'm not sure if this fixes #113. The issue with using discouraged static linking is still open. But maybe worth creating an extra ticket for this?

@nachovizzo
Copy link
Collaborator

Strange… last time I've checked, cmake was not supported. But looks this is now supported. Terrific news!

I agree that the static linking should be investigated separately given that there was such an easy fix for the upstream. I will debug the produced symbols for a bit and merge this afterward.

@nachovizzo
Copy link
Collaborator

@ahans When I run $ cibuildwheel --platform linux --output-dir wheelhouse ./python/:
locally, I get: /opt/rh/devtoolset-10/root/usr/libexec/gcc/x86_64-redhat-linux/10/ld: cannot find -ltb

Have you seen this problem? On the CI looks to be working 🤔 , but this is now suspicious

@ahans
Copy link
Contributor Author

ahans commented Apr 5, 2023

@ahans When I run $ cibuildwheel --platform linux --output-dir wheelhouse ./python/: locally, I get: /opt/rh/devtoolset-10/root/usr/libexec/gcc/x86_64-redhat-linux/10/ld: cannot find -ltb

Have you seen this problem? On the CI looks to be working thinking , but this is now suspicious

I don't know cibuildwheel, but can have a look. But exactly does "running locally" mean in your case?

@nachovizzo
Copy link
Collaborator

@ahans When I run $ cibuildwheel --platform linux --output-dir wheelhouse ./python/: locally, I get: /opt/rh/devtoolset-10/root/usr/libexec/gcc/x86_64-redhat-linux/10/ld: cannot find -ltb
Have you seen this problem? On the CI looks to be working thinking , but this is now suspicious

I don't know cibuildwheel, but can have a look. But exactly does "running locally" mean in your case?

So cibuildwheel is the tool I use to, well, build the python wheels. It's like an automation tool, that use docer of course, to build Python wheel that requiere some binary code.

to reproduce, just pip install cibuildwheel and then run the command above. This will launch the build process, for the different python versions specified in the pyproject.tom file

* Update custom flags for tbb build
* Add lib64 to TBBHelper lib dirs

Co-authored-by: Ignacio Vizzo <ignaciovizzo@gmail.com>
@ahans
Copy link
Contributor Author

ahans commented Apr 5, 2023

to reproduce, just pip install cibuildwheel and then run the command above. This will launch the build process, for the different python versions specified in the pyproject.tom file

Alright, I was able to repro. Looks like on that RedHat-based distro libs go into lib64 instead of lib. Not sure how CMake figures that out. We could probably use the same logic in tbb.cmake. I now just added lib64 to the lib directories. I'd say that's fine.

@ahans
Copy link
Contributor Author

ahans commented Apr 5, 2023

Looks like I found a nicer way now. I guess CMAKE_INSTALL_LIBDIR is also what TBB uses and your custom TBB was not 100% correct set up in that respect.

@ahans
Copy link
Contributor Author

ahans commented Apr 5, 2023

Oh well, now the Ubuntu builds fail. Going back to listing both, lib as well as lib64.

@nachovizzo
Copy link
Collaborator

@ahans Merging this so I can create a new release to debug the release pipeline after this change. Thanks again!

@nachovizzo nachovizzo merged commit eeb33b2 into PRBonn:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade tbb to an official version and drop nacho's fork
2 participants