Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get absolute path first in case . is data_dir #321

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

benemer
Copy link
Member

@benemer benemer commented Apr 11, 2024

@louis-wiesmann caught a small bug when running the kiss_icp_pipeline directly in the data folder. The generic data loader will use the "." as the sequence_dir, and the poses will be saved to ._poses.txt and will therefore be hidden 😆

This should fix it.

Copy link
Collaborator

@nachovizzo nachovizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch kartoffelone!

@nachovizzo nachovizzo removed the ros label Apr 11, 2024
Copy link
Collaborator

@tizianoGuadagnino tizianoGuadagnino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@tizianoGuadagnino tizianoGuadagnino merged commit 05e7ef0 into main Apr 11, 2024
17 checks passed
@tizianoGuadagnino tizianoGuadagnino deleted the benedikt/fix-hidden-pose-file branch April 11, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants