Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeLiPR: Make sure chunk size is sufficient #338

Merged
merged 1 commit into from
May 7, 2024

Conversation

benemer
Copy link
Member

@benemer benemer commented May 6, 2024

When reading HeLiPR data, in some sequences (for example Roundabout02) the last chunk of data is incomplete and Kiss fails with

error: unpack_from requires a buffer of at least 999400 bytes for unpacking 25 bytes at offset 999375 (actual buffer size is 999383)

This PR fixes this by ensuring we have enough data to read in the last chunk.

@benemer benemer changed the title Make sure chunk size is sufficient HeLiPR: Make sure chunk size is sufficient May 6, 2024
@benemer benemer added the python label May 6, 2024
@nachovizzo
Copy link
Collaborator

Should I download this dataset 😂?

@tizianoGuadagnino tizianoGuadagnino merged commit 4225185 into main May 7, 2024
17 checks passed
@tizianoGuadagnino tizianoGuadagnino deleted the benedikt/helipr_fix_binary_unpacking branch May 7, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants