Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unncessary python list appends #373

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

saurabh1002
Copy link
Contributor

  1. Python lists and list appends were used to store odomtery poses and execution times
  2. But we already know the expected length of these variables
  3. So, we can use numpy arrays directly

Copy link
Member

@benemer benemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you directly open a branch on this repo next time? In that case we can change minor things ourselves like this visualizer update 🙏

python/kiss_icp/pipeline.py Outdated Show resolved Hide resolved
@tizianoGuadagnino tizianoGuadagnino merged commit e2364f2 into PRBonn:main Jul 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants