build: Bump toolchain, test prqlc for msrv
#2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rust-analyzer` is now raising mistaken errors for 1.65, as they only support the latest version rust-lang/rust-analyzer#12751 (comment) We don't want to bump the required version because of PRQL#1561, but I think this approach: - Lets us work on an updated version - Tests `prql-compiler` & `prqlc` to ensure they don't fail to support 1.65 - Doesn't let us use any new features in `prql-compiler` or `prqlc` until we bump the required version, but that's completely fine (is there even _anything_ we'd use?)
eitsupi
reviewed
May 24, 2023
aljazerzen
approved these changes
May 24, 2023
No, I've checked. |
max-sixty
added a commit
to max-sixty/prql
that referenced
this pull request
May 24, 2023
In PRQL#2621 I realized that we didn't have to couple these — sorry for overcomplicating previously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-analyzeris now raising mistaken errors for 1.65, as they only support the latest version rust-lang/rust-analyzer#12751 (comment)We don't want to bump the required version because of #1561, but I think this approach:
prql-compiler&prqlcto ensure they don't fail to support 1.65prql-compilerorprqlcuntil we bump the required version, but that's completely fine (is there even anything we'd use?)