Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 공지사항 API #49

Merged
merged 4 commits into from
Aug 5, 2023
Merged

[feat] 공지사항 API #49

merged 4 commits into from
Aug 5, 2023

Conversation

chaerlo127
Copy link
Collaborator

🌱 이슈 번호

close #48


💬 기타 사항

  • 파이 팅팅팅

@chaerlo127 chaerlo127 added 🔮 feat 기능을 생성해요 ! 🐣 chae-eun 채은이가 만든 기능이에요 ! 👥 cs cs 도메인 기능이에요 ! labels Aug 4, 2023
@chaerlo127 chaerlo127 self-assigned this Aug 4, 2023
psyeon1120
psyeon1120 reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@psyeon1120 psyeon1120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

케키와 냉집사의 잔해.....ㅋㅋㅋㅋㅋㅋㅋ

src/main/kotlin/com/psr/psr/cs/controller/CsController.kt
/**
* 공지사항 상세
*/
@GetMapping("/notices/{noticeIdx}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idx 다요 밑에도 다 idx 다요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞다 id.. ㅋㅅㅋ..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그 클라에서 pathVariable로 받는 것도 id로 통일하는거 어때여

sojungpp
sojungpp approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@sojungpp sojungpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귯귯 !!!! 언니가 말한 idx 부분만 바꾸면 될 것 같네유 (나도 맨날 헷갈림ㅋ.ㅋ)

@chaerlo127 chaerlo127 merged commit 80ce7df into develop Aug 5, 2023
1 check passed
@chaerlo127 chaerlo127 deleted the feat/#48-getNotices-Lists branch August 17, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sojungpp sojungpp sojungpp approved these changes

@psyeon1120 psyeon1120 psyeon1120 approved these changes

Assignees

@chaerlo127 chaerlo127

Labels
🐣 chae-eun 채은이가 만든 기능이에요 ! 👥 cs cs 도메인 기능이에요 ! 🔮 feat 기능을 생성해요 !
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 공지사항 API
3 participants
@chaerlo127 @psyeon1120 @sojungpp