Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] 문의 목록 조회 response 형태 변경 #63

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

psyeon1120
Copy link
Member

🌱 이슈 번호

close #55


💬 기타 사항

  • JPA는 null인 리스트를 반환하지 않아요.....

@psyeon1120 psyeon1120 added ☀️ seoyeon 서연이가 만든 기능이에요 ! 🌿 refactor 코드 구조를 변경해요 ! ✉️ inquires 문의하기 도메인 기능이에요 ! labels Aug 5, 2023
@psyeon1120 psyeon1120 requested a review from a team August 5, 2023 16:09
@psyeon1120 psyeon1120 self-assigned this Aug 5, 2023
Comment on lines +8 to +10
@JsonInclude(JsonInclude.Include.NON_NULL)
val content: String?,
@JsonInclude(JsonInclude.Include.NON_NULL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 야무진 이사람들

Copy link
Collaborator

@chaerlo127 chaerlo127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💕💕

inquiryRepository.findByUserAndInquiryStatusAndStatus(user, inquiryStatus, ACTIVE_STATUS)
?: throw BaseException(BaseResponseCode.NOT_FOUND_INQUIRY)
inquiryRepository.findByUserAndInquiryStatusAndStatus(user, inquiryStatus, ACTIVE_STATUS))
.map { inquiry: Inquiry -> inquiryAssembler.toPrepareListDto(inquiry) }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제는 람다의 신이 되어버린 그녀..⭐️

@psyeon1120 psyeon1120 merged commit befa2cb into develop Aug 5, 2023
1 check passed
@psyeon1120 psyeon1120 deleted the refactor/#55-list-response branch August 5, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✉️ inquires 문의하기 도메인 기능이에요 ! 🌿 refactor 코드 구조를 변경해요 ! ☀️ seoyeon 서연이가 만든 기능이에요 !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] 문의하기 목록 조회 Response 형태 변경
3 participants