Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named pankus #9

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

mdodkins
Copy link

This finally became urgent enough for me to do it today, haha

Let me know what you think. At first I tried to make it work with a templated name argument (using a user type), but as the whole thing is macro'd up that caused me some unfortunate problems, so I went with the macro argument approach instead.

I did try and avoid duplication of the tests, but they're quite coupled to the Metaprogram. I took a few steps toward de-coupling them (as you can see, I could remove the #include from the top of the TypeList tests...) but backed out after I saw how tightly coupled the tests are to the types that are generated by the macro instantiation.

Fun few hours anyway!

@PabloMansanet
Copy link
Owner

Woah, what a throwback! 😄

I haven't touched C++ in about... 2 or 3 years now? But I'm excited to look into this anyway. I will find time to give a review over the week :)

@mdodkins
Copy link
Author

mdodkins commented Feb 5, 2024

Bump

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants