Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

352 bug some alarms are not being printed #353

Merged
merged 10 commits into from
Jan 11, 2023

Conversation

Paciente8159
Copy link
Owner

Redesigned internal machine states:

  • fixed multi drive axis compilation error
  • added limit alarm with no motion (no reset required)
  • replaced halt state by not homed
  • added limits exec state
  • high priority (lower values) alarms now require user reset (hard or soft reset)
  • prevent reset loop while emergency stop is pressed

- redesigned internal machine states
- fixed multi drive axis compilation error
- added limit alarm with no motion
- replaced halt state by not homed
- added limits state
- high priority alarms now require user reset
- fixed negative alarm state messages
- prevent reset loop while emergency stop is pressed
@Paciente8159 Paciente8159 added bug Something isn't working needs: testing needs: testing core: general core: general enhancement enhancement labels Jan 9, 2023
@Paciente8159 Paciente8159 linked an issue Jan 9, 2023 that may be closed by this pull request
@Paciente8159 Paciente8159 mentioned this pull request Jan 9, 2023
- state clear function for not homed status
- probing motion fixed to clear not homed after initial probe contact via unlock command
- removed safety door code if safety pin undefined (like stated in Grbl)
- modified interlocking to terminate JOG motion after DOOR is opened
- homing now possible with hard limits disabled
- with hard limits disabled endstop can be triggered in run mode
- unlock command only reset parser stopping group (preserves the parser state)
- removed duplicated itp run condition check
- fixed parser modal states active protocol print that added the group 0 mantissa to other groups as well
@Paciente8159 Paciente8159 merged commit 563861f into master Jan 11, 2023
@Paciente8159 Paciente8159 deleted the 352-bug-some-alarms-are-not-being-printed branch January 11, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core: general core: general enhancement enhancement needs: testing needs: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some alarms are not being printed
1 participant