Change homing alarm failure type #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are correct. It should be EXEC_ALARM_HOMING_FAIL_PULLOFF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a mistake in the alarm triggered after homing axis pull off fails, instead of firing
EXEC_ALARM_HOMING_FAIL_PULLOFF,EXEC_ALARM_HOMING_FAIL_APPROACHgets sent and confusion ensues. This small pull request addresses this issue. After a quick check, the definition ofEXEC_ALARM_HOMING_FAIL_PULLOFFdidn't seem to be used anywhere in the project which is why I believe this is a simple typo.