Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPI implementation for STM32 MCUs #699

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix SPI implementation for STM32 MCUs #699

merged 1 commit into from
Jul 17, 2024

Conversation

patryk3211
Copy link
Contributor

Fixed some minor issues with the SPI implementation in STM32 family microcontrollers.

  • Missing 'bitwise not' operator before clearing bits in control register 1
  • Polling SPI1 in xmit instead of the configured SPI_REG

@patryk3211 patryk3211 marked this pull request as ready for review July 17, 2024 10:01
@Paciente8159
Copy link
Owner

Awesome. Thanks.

@Paciente8159 Paciente8159 added bug Something isn't working HAL: STM32F1x HAL: STM32F1x HAL: STM32F4x HAL: STM32F4x HAL: STM32F0x HAL: STM32F0x labels Jul 17, 2024
@Paciente8159 Paciente8159 merged commit 5e9dd17 into Paciente8159:master Jul 17, 2024
19 checks passed
@patryk3211 patryk3211 deleted the stm32_spi_fix branch July 18, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working HAL: STM32F0x HAL: STM32F0x HAL: STM32F1x HAL: STM32F1x HAL: STM32F4x HAL: STM32F4x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patryk3211 @Paciente8159