Skip to content

Commit

Permalink
refine FLAGS approval
Browse files Browse the repository at this point in the history
  • Loading branch information
@sneaxiy
sneaxiy committed Sep 22, 2021
1 parent 1238115 commit ad76e4a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/check_file_diff_approvals.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ function run_tools_test() {
cd ${CUR_PWD}
}

changed_env_var_count=`git diff -U0 upstream/$BRANCH ${PADDLE_ROOT}/paddle | grep -E 'DEFINE_EXPORTED|DEFINE_bool|DEFINE_int32|DEFINE_int64|DEFINE_uint64|DEFINE_double|DEFINE_string' | wc -l`
changed_env_var_count=`git diff -U0 upstream/$BRANCH ${PADDLE_ROOT}/paddle | grep 'DEFINE_EXPORTED' | wc -l`
if [[ $changed_env_var_count -gt 0 ]]; then
echo_line="You must have one RD (lanxianghit (Recommend), phlrain or luotao1) approval for changing the FLAGS, which manages the environment variables.\n"
check_approval 1 6836917 47554610 43953930
Expand Down

1 comment on commit ad76e4a

@paddle-bot-old
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅Congratulation! Your pull request passed all required CI. You could ask reviewer(s) to approve and merge. 🎉

Please sign in to comment.