Skip to content

Commit

Permalink
【PIR OpTest Fix No.3】 fix test_matrix_rank_op (#59959)
Browse files Browse the repository at this point in the history
* fix

* fix

* Update op_translator.cc

* Update op_translator.cc

* Update op_translator.cc

* Update op_translator.cc

* fix

* fix codestyle
  • Loading branch information
xingmingyyj committed Dec 22, 2023
1 parent 5a236ef commit deef032
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 0 deletions.
6 changes: 6 additions & 0 deletions paddle/fluid/ir_adaptor/translator/op_compat_gen.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,12 @@ def insert_new_mutable_attributes(
}
op_arg_name_mappings["matmul"] = {"x": "X", "y": "Y", "out": "Out"}

op_arg_name_mappings["matrix_rank"] = {
"x": "X",
"atol_tensor": "TolTensor",
"out": "Out",
}

op_name_normailzer_template = env.get_template("op_compat_info.cc.j2")
with open(output_source_file, 'wt') as f:
op_compat_definition = op_name_normailzer_template.render(
Expand Down
21 changes: 21 additions & 0 deletions paddle/fluid/ir_adaptor/translator/op_translator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2671,6 +2671,26 @@ struct FusedElemwiseAddActivationGradOpTranscriber
}
};

struct MatrixRankOpTranscriber : public OpTranscriber {
pir::OpInfo LoopkUpOpInfo(pir::IrContext* ctx,
const OpDesc& op_desc) override {
std::string target_op_name = "";
if (op_desc.HasInput("TolTensor") && !op_desc.Input("TolTensor").empty()) {
target_op_name = "pd_op.matrix_rank_tol";
} else {
target_op_name = "pd_op.matrix_rank";
}
const auto& op_info = ctx->GetRegisteredOpInfo(target_op_name);
if (!op_info) {
IR_THROW(
"Op matrix_rank should have corresponding OpInfo pd_op.matrix_rank "
"or "
"pd_op.matrix_rank_tol.");
}
return op_info;
}
};

struct LodArrayLengthOpTranscriber : public OpTranscriber {
pir::OpInfo LoopkUpOpInfo(pir::IrContext* ctx,
const OpDesc& op_desc) override {
Expand Down Expand Up @@ -2956,6 +2976,7 @@ OpTranslator::OpTranslator() {
special_handlers["split"] = SplitOpTranscriber();
special_handlers["sum"] = AddNOpTranscriber();
special_handlers["tril_triu"] = TrilAndTriuOpTranscriber();
special_handlers["matrix_rank"] = MatrixRankOpTranscriber();
special_handlers["mul"] = MulOpTranscriber();
special_handlers["mul_grad"] = MulGradOpTranscriber();
special_handlers["select_input"] = SelectInputOpTranscriber();
Expand Down
1 change: 1 addition & 0 deletions test/white_list/pir_op_test_white_list
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ test_matmul_v2_op
test_matmul_v2_op_static_build
test_matrix_nms_op
test_matrix_power_op
test_matrix_rank_op
test_maxout_op
test_mean_op
test_memcpy_op
Expand Down

0 comments on commit deef032

Please sign in to comment.