Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python version evaluate function #1036

Merged
merged 3 commits into from
Jan 2, 2017

Conversation

dayhaha
Copy link
Contributor

@dayhaha dayhaha commented Dec 29, 2016

fix #1035
As evaluate.sh don't work in Mac, I add a python version evaluate function. The output is the same as evaluete.sh

➜  src git:(develop) ✗ ./evaluate.py mlp_train.log
Best pass is 00085, error is 0.164746, which means predict get error as 0.202945
The classification accuracy is 97.44%
evaluating from pass output/pass-00085

import math


def get_best_pass(filename):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filname ==> log_filename 这样更具体一些,让人知道这个函数的输入是什么

https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done,谢谢指出!

@dayhaha dayhaha merged commit 495649a into PaddlePaddle:develop Jan 2, 2017
zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this pull request Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grep error
2 participants