Fix fetch_op_handle #10454
Merged
Fix fetch_op_handle #10454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
reviewed
May 7, 2018
| @@ -61,9 +61,14 @@ void FetchOpHandle::RunImpl() { | |||
| auto &scope = scopes[i]; | |||
| auto *var = | |||
| scope->FindVar(kLocalExecScopeName)->Get<Scope *>()->FindVar(var_name); | |||
| if (var == nullptr) { | |||
| scope->FindVar(var_name); | |||
There was a problem hiding this comment.
Oh, right, scope->FindVar(kLocalExecScopeName)->Get<Scope *>() is the subscope of scope.
reyoung
reviewed
May 7, 2018
| @@ -49,7 +49,7 @@ void FetchOpHandle::RunImpl() { | |||
| platform::DeviceContextPool::Instance().Get(platform::CPUPlace()); | |||
| for (auto *input : inputs_) { | |||
| auto *var = static_cast<VarHandle *>(input); | |||
| var->generated_op_->Wait(cpu_ctx); | |||
| if (var->generated_op_) var->generated_op_->Wait(cpu_ctx); | |||
panyx0718
previously approved these changes
May 8, 2018
| # TODO(zcd): I found that onece the memory optimizer is open, | ||
| # parallel_exe doesn't fetch some variable, such as conv2d_0.b_0@GRAD, | ||
| # conv2d_1.b_0@GRAD. Those variables should not be pruned. | ||
| # fluid.memory_optimize(main) |
There was a problem hiding this comment.
Nice!
Recently, qingqing reported that se-resnext accuracy improved after memory_optimize is turned off.
There was a problem hiding this comment.
Maybe this proves that the memory_optimize have some problems.
| fetch_list = [] | ||
| all_vars = main.global_block().vars | ||
| for k, v in all_vars.iteritems(): | ||
| if 'velocity' not in k: |
There was a problem hiding this comment.
velocity also can be fetched, I only think velocity is unnecessary to be fetched.
| for data in train_inputs: | ||
| ret = pe.run(fetch_list, feed=feeder.feed(data)) | ||
| for i in range(len(fetch_list)): | ||
| print("%s - %s" % (fetch_list[i], np.sum(ret[i]))) |
There was a problem hiding this comment.
Let's try to avoiding printing a lot in tests.
There was a problem hiding this comment.
Ok, I will fix this.
panyx0718
previously approved these changes
May 8, 2018
panyx0718
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10457