Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put all new tests under high-level-api #10534

Merged
merged 2 commits into from
May 9, 2018
Merged

Put all new tests under high-level-api #10534

merged 2 commits into from
May 9, 2018

Conversation

jetfuel
Copy link
Contributor

@jetfuel jetfuel commented May 9, 2018

This is to re organize the test folder to have them all under the folder high-level-api first.

After this we can create individual PR for each test category to start our test-driven development.

@jetfuel jetfuel self-assigned this May 9, 2018
@jetfuel jetfuel requested a review from wangkuiyi May 9, 2018 19:11
Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, can you please rename the folder test_recognize_digits to just recognize_digits?

Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jetfuel jetfuel merged commit 0fed3db into develop May 9, 2018
@jetfuel jetfuel deleted the reorganizeTests branch May 9, 2018 21:05
putcn pushed a commit to putcn/Paddle that referenced this pull request May 10, 2018
* Put all new tests under high-level-api

* be consistent with the naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants