Cosine Similarity Paddle Function. #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianbingsz
force-pushed
the
paddle_func
branch
from
2290502
to
294042f
Compare
hedaoyuan
requested changes
Jan 10, 2017
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|
|
||
| #pragma once |
There was a problem hiding this comment.
CosSimVecMatLayer.h还是跟CosSimVecMatLayer.cpp写在一起好，并没有另外一个文件需要include "CosSimVecMatLayer.h"
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|
|
||
| #include <gtest/gtest.h> |
There was a problem hiding this comment.
Test的写法还是比较复杂，对于只是Check CPU/GPU是否一致的test case还是得实现一个更简便的方法来做。
tianbingsz
force-pushed
the
paddle_func
branch
from
a7b2929
to
70733b5
Compare
tianbingsz
force-pushed
the
paddle_func
branch
from
70733b5
to
e28dc0c
Compare
|
@hedaoyuan , 用新的FunctionTest重写了一下unit test, address 了你的comments.如果没有什么问题的话，可否approve一下(你新的两个op可以再开一个PR写一下)？ |
hedaoyuan
reviewed
Feb 7, 2017
| @@ -117,17 +127,25 @@ void CosSimVecMatLayer::forward(PassType passType) { | |||
| } | |||
|
|
|||
| MatrixPtr outV = getOutputValue(); | |||
|
|
|||
| CHECK(outV && inV0 && inV1); | |||
| REGISTER_TIMER_INFO("FwCosVMTimer", getName().c_str()); | |||
| for (size_t i = 0; i < batchSize; i++) { | |||
There was a problem hiding this comment.
这个for (size_t i = 0; i < batchSize; i++)可以放到CosSimForwardFunc里面，同时Layer可以去掉这些tmp matrix。backward也一样可以去掉for (size_t i = 0; i < batchSize; i++)。
CosSimForwardFunc区分是被CosSimVecMatLayer还是CosSimLayer调用应该是通过inputs[0]，inputs[1]的参数类型上判断（shape不一样）。另外，也不建议在CosSimForwardFunc里面增加for (size_t i = 0; i < batchSize; i++)，API应该可以直接支持。
hedaoyuan
approved these changes
Feb 7, 2017
added 8 commits
February 8, 2017 11:11
tianbingsz
force-pushed
the
paddle_func
branch
from
e28dc0c
to
ae3ae08
Compare
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
* feat: add cnn_dailymail dataset * fix: correct error message * refactor: use paddlenlp decompress api * docs: add doc for cnn_dm
lizexu123
pushed a commit
to lizexu123/Paddle
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosine Similarity Task for Paddle Function APIs (#977)