Simplify label_semantic_roles book example using new LoDTensor API #10886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kexinzhao
force-pushed
the
label_semantic_roles_lod
branch
2 times, most recently
from
b4c66c2
to
8c1b2fc
Compare
sidgoyal78
reviewed
May 24, 2018
There was a problem hiding this comment.
Thanks for the PR. There are some changes to this PR, please see #10757
Can you please wait for that to get merged?
|
Sure |
sidgoyal78
reviewed
May 24, 2018
There was a problem hiding this comment.
@kexinzhao : Can you now modify? The code merged in is now working.
kexinzhao
force-pushed
the
label_semantic_roles_lod
branch
from
0bcaf67
to
6133728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check #10735 for why we are doing this.
To solve the issue above, we have merged a PR #10817 and now there is utility functions here to create LoDTensor.
So this means that we can simplify the book example code using the new API.
This PR tries to simplify the old label_semantic_roles book example.