Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reader dependency pass #23301

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Add reader dependency pass #23301

merged 1 commit into from
Apr 1, 2020

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Mar 30, 2020 •
edited
Loading

Add a reader dependency pass to make sure all ops must run after read op runs. This is designed to avoid the following cases:

input_data = read_op()
x = any_inplace_op_that_does_not_rely_on_read_op(x)

If read op does not run before any_inplace_op_that_does_not_rely_on_read_op, x would be changed even though there is no data in the current batch. It is extremely serious in learning rate decay cases.

@sneaxiy sneaxiy requested a review from chenwhql March 31, 2020 04:16
chenwhql
chenwhql approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 3a21980 into PaddlePaddle:develop Apr 1, 2020
@sneaxiy sneaxiy deleted the add_reader_dep_pass branch April 1, 2020 14:30
mapingshuo pushed a commit to mapingshuo/Paddle that referenced this pull request Apr 7, 2020
@sneaxiy @mapingshuo
add reader dependency pass, test=develop (PaddlePaddle#23301)
0583fee
@From00 From00 mentioned this pull request Jul 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sneaxiy @chenwhql