Get OpProtos in Python #2864
Merged
Get OpProtos in Python #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PyBind and SWIG of paddle cannot be load in a single Python process, lazy import all SWIG library of Paddle. Otherwise, the glog, gflags are imported twice in a same Python process. * Note that all PyBind11 return C++ std::string as an unicode. For protobuf, it is need be cast to `str` before use them. * Add unit test for Get `OpProtos`
jacquesqiao
reviewed
Jul 14, 2017
|
|
||
| namespace py = pybind11; | ||
| namespace pd = paddle::framework; | ||
|
|
||
| USE_OP(add_two); |
There was a problem hiding this comment.
是的。可以单独放一个.cc里面，而且那个.cc应该也可以是编译器生成的。
jacquesqiao
reviewed
Jul 14, 2017
python/paddle/v2/optimizer.py
Outdated
| @@ -26,6 +24,8 @@ def __impl__(): | |||
|
|
|||
| self.__opt_conf_proto__ = config_parser_utils.parse_optimizer_config( | |||
| __impl__) | |||
| if swig_api is None: | |||
There was a problem hiding this comment.
It is a bug. Done.
jacquesqiao
reviewed
Jul 14, 2017
| protostrs = core.get_all_op_protos() | ||
| ret_values = [] | ||
| for pbstr in protostrs: | ||
| op_proto = op_proto_pb2.OpProto.FromString(str(pbstr)) |
There was a problem hiding this comment.
if this str() method the way to fix the Unicode problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lazy import all SWIG library of Paddle. Otherwise, the glog, gflags
are imported twice in a same Python process.
protobuf, it is need be cast to
strbefore use them.OpProtos