-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add param_attr parameter for img_conv_groups(...) in /python/trainer_config_helpers/networks.py #3009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 不过既然改了,可以把这个函数的注释补充完整么,thx!!
modify the format
:type pool_stride: int | ||
:param pool_type: pooling type. | ||
:type pool_type: BasePoolingType | ||
:param param_attr: see img_conv_layer for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看了img_conv_layer的param_attr: Convolution param attribute. None means default attribute。直接复制过来?或者你说的不是这句?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯, 可以复制过来,我修改一下
add
param_attr
parameter forimg_conv_groups(...)
in/python/trainer_config_helpers/networks.py