Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add param_attr parameter for img_conv_groups(...) in /python/trainer_config_helpers/networks.py #3009

Merged
merged 7 commits into from
Jul 25, 2017

Conversation

NHZlX
Copy link
Contributor

@NHZlX NHZlX commented Jul 21, 2017

add param_attr parameter for img_conv_groups(...) in /python/trainer_config_helpers/networks.py

@NHZlX NHZlX requested a review from luotao1 July 21, 2017 08:25
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 不过既然改了,可以把这个函数的注释补充完整么,thx!!

:type pool_stride: int
:param pool_type: pooling type.
:type pool_type: BasePoolingType
:param param_attr: see img_conv_layer for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看了img_conv_layer的param_attr: Convolution param attribute. None means default attribute。直接复制过来?或者你说的不是这句?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯, 可以复制过来,我修改一下

@NHZlX NHZlX merged commit 0d26a15 into PaddlePaddle:develop Jul 25, 2017
@NHZlX NHZlX deleted the add_paramAttr branch July 25, 2017 03:45
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants