ENH: for clarity, change DLOG to VLOG #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superjomn
reviewed
Jul 27, 2017
| @@ -27,12 +27,11 @@ BuddyAllocator::BuddyAllocator(SystemAllocator* system_allocator, | |||
| system_allocator_(std::move(system_allocator)) {} | |||
|
|
|||
| BuddyAllocator::~BuddyAllocator() { | |||
| DLOG(INFO) << "BuddyAllocator Disconstructor makes sure that all of these " | |||
| "have actually been freed"; | |||
| VLOG(3) << "BuddyAllocator Disconstructor makes sure that all of these " | |||
There was a problem hiding this comment.
do 3 has a common meaning? or maybe a uniform definition
enum {
LOW = 0,
DEBUG0 = 1,
DEBUG1 = 2,
DEBUG2 = 3
};
VLOG(DEBUG2) << "some info";better?
There was a problem hiding this comment.
I vaguely remember that 3 is the right choice because what we need to do is to run paddle with --log_level=3 command parameter.
wangkuiyi
approved these changes
Jul 27, 2017
| @@ -27,12 +27,11 @@ BuddyAllocator::BuddyAllocator(SystemAllocator* system_allocator, | |||
| system_allocator_(std::move(system_allocator)) {} | |||
|
|
|||
| BuddyAllocator::~BuddyAllocator() { | |||
| DLOG(INFO) << "BuddyAllocator Disconstructor makes sure that all of these " | |||
| "have actually been freed"; | |||
| VLOG(3) << "BuddyAllocator Disconstructor makes sure that all of these " | |||
There was a problem hiding this comment.
I vaguely remember that 3 is the right choice because what we need to do is to run paddle with --log_level=3 command parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.