[CustomOP] Add shape related constructor for Tensor #31681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
JiabinYang
changed the title
JiabinYang
force-pushed
the
refine_custom_op
branch
from
df3d1c1
to
80db24b
Compare
chenwhql
reviewed
Mar 23, 2021
| : tensor_(std::make_shared<framework::LoDTensor>()), | ||
| place_(place), | ||
| stream_(StreamWrapper()) { | ||
| reshape(shape); |
There was a problem hiding this comment.
这里直接调用Resize吧，构造函数是我们提供的接口，这里不需要警告用户
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Describe
This PR try to add a shape related constructor for
paddle::Tensor, and give user more instruction about using ofpaddle::Tensor::reshape