Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hybrid Parallel] Support dp & mp in dygraph #32323

Merged
merged 7 commits into from
Apr 19, 2021
Merged

[Hybrid Parallel] Support dp & mp in dygraph #32323

merged 7 commits into from
Apr 19, 2021

Conversation

ForFishes
Copy link
Member

PR types

New features

PR changes

Others

Describe

Support dp & mp in dygraph

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

sandyhouse
sandyhouse approved these changes Apr 19, 2021
View reviewed changes
Copy link

@sandyhouse sandyhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/paddle/fluid/dygraph/parallel.py
if memory_counter < group_size and dtype == var.dtype:
memory_counter += bytes
else:
memory_counter = 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 'memory_counter = bytes'

@ForFishes ForFishes merged commit ffd4086 into PaddlePaddle:develop Apr 19, 2021
@ForFishes ForFishes deleted the support_mp_dp branch April 19, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandyhouse sandyhouse sandyhouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ForFishes @sandyhouse