Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove thrust include files #32395

Merged

Conversation

Avin0323
Copy link
Contributor

@Avin0323 Avin0323 commented Apr 20, 2021

PR types

Others

PR changes

Others

Describe

删除thrust库冗余include的头文件。

thrust库仅在个别OP中使用,但在lod_tensor.h中include,lod_tensor.h被每个OP文件include,导致全部的OP对应cu文件需要预处理相关的头文件。

删除该头文件后,代码展开优化8万行,占比约30%左右。

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Avin0323 Avin0323 changed the title [WIP]remove thrust include files remove thrust include files Apr 21, 2021
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit ab6f874 into PaddlePaddle:develop Apr 21, 2021
@Avin0323 Avin0323 deleted the optimize-include-for-compilation branch April 21, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants