[CustomOp]Remove paddle_custom_op dynamic libraries, and link to FLUID_CORE on Windows #32583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhwesky2010
changed the title
|
Thanks for your contribution! |
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
4292a39
to
906c992
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
906c992
to
d9ba542
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
d9ba542
to
20f6e11
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
20f6e11
to
e802ef4
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
e802ef4
to
4ec1a90
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
4ec1a90
to
d811d05
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
d811d05
to
8eb2e4c
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
8eb2e4c
to
aff31aa
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
aff31aa
to
225a4af
Compare
…on windows, and check copy_to
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
225a4af
to
3290850
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
acc6289
to
51d428f
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
51d428f
to
21f2875
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
21f2875
to
859197e
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
2457a08
to
e743594
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
e743594
to
4a78456
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
4a78456
to
829beca
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
829beca
to
ed398ab
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
3 times, most recently
from
469a64b
to
c060331
Compare
zhwesky2010
force-pushed
the
fix_windows_customop
branch
from
c060331
to
d4b0ac6
Compare
luotao1
approved these changes
May 7, 2021
zhwesky2010
added a commit
to zhwesky2010/Paddle
that referenced
this pull request
May 7, 2021
…Windows (PaddlePaddle#32583) * Remove paddle_custom_op dynamic libraries, change link to FLUID_CORE on windows, and check copy_to * fix CI
zhwesky2010
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
移除旧的
paddle_custom_op动态库生成过程，并在Windows上复用到已有的core动态库paddle_custom_op动态库存在两个问题：paddle_custom_op动态库与core动态库，两个动态库会存在全局instance冲突，例如op_info_map；core动态库里，那么paddle_custom_op动态库将会缺失这种类型的instance，导致某些功能无法使用。这些问题在Unix、Windows均会存在，因此需要复用
core动态库，该PR调整了Windows动态库的设计，使用Windows软链+硬链的组合方式给用户提供core动态库的链接方式，是#31976 的后续。