Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HybridParallel] update collective split to use c_embedding and mp_allreduce #33411

Merged
merged 2 commits into from
Jun 9, 2021
Merged

[HybridParallel] update collective split to use c_embedding and mp_allreduce #33411

merged 2 commits into from
Jun 9, 2021

Conversation

wangxicoding
Copy link
Contributor

@wangxicoding wangxicoding commented Jun 8, 2021 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

_c_lookup_table and _mp_allreduce support static.
update collective.split to use _c_lookup_table and _mp_allreduce.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wangxicoding wangxicoding changed the title c_embedding and mp_allreduce support static [HybridParallel] c_embedding and mp_allreduce support static Jun 8, 2021
@wangxicoding wangxicoding changed the title [HybridParallel] c_embedding and mp_allreduce support static [HybridParallel] update collective split to use c_embedding and mp_allreduce Jun 8, 2021
sandyhouse
sandyhouse approved these changes Jun 9, 2021
View reviewed changes
Copy link

@sandyhouse sandyhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ForFishes
ForFishes approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxicoding wangxicoding merged commit 42c1297 into PaddlePaddle:develop Jun 9, 2021
@wangxicoding wangxicoding deleted the c_emb_static branch June 21, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandyhouse sandyhouse sandyhouse approved these changes

@ForFishes ForFishes ForFishes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangxicoding @sandyhouse @ForFishes