Combine amp and qat #33484
Merged
Combine amp and qat #33484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiu
reviewed
Jun 17, 2021
Comment on lines
188
to
196
| if (op_type == "moving_average_abs_max_scale") { | ||
| for (const auto& pair : ins) { | ||
| if (pair.first == "X" && | ||
| pair.second.front()->DataType() == | ||
| framework::proto::VarType::FP16) { | ||
| dst_type = framework::proto::VarType::FP16; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
can it be handled like "batch_norm", as the code below?
There was a problem hiding this comment.
moving_average_abs_max_scale only considers the dtype of input(X) to determine the dest_type. However, "batch_norm" just cast the input(X) to FP16 or FP32. These are two different cases.
|
Sorry to inform you that bbe2e45's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe