Add AXPY oneDNN handler #33632
Merged
Add AXPY oneDNN handler #33632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Compilation of this function is possible only when Paddle is not build with CUDA nor HIP.
|
Thanks for your contribution! |
|
@jczaja @arlesniak Please review it. Now PR-CI-APPROVAL and PR-CI-OP-benchmark all passed. If you leave LGTM it will be merged. Adam's commit record keep the same I just removed skip_bf16 in last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
This PR is to take over PR #33046. This PR introduces oneDNN AXPY handler providing BLAS::AXPY interface. The use of this handler is enabled at this moment only for
bfloat16data type forsumoperator withSelectedRowsinput tensors. It gives almost 10% performance improvement on CPX machine. This PR speeds up SGD operator with Selected rows with AXPY handler.