add new inplace api Tensor.fill_, Tensor.zero_ #33829

zhiboniu · 2021-06-29T06:29:00Z

PR types

New features

PR changes

APIs

Describe

add new inplace api Tensor.fill_, Tensor.zero_

        #paddle.Tensor.fill_()示例：
        import paddle
        tensor = paddle.to_tensor([0, 1, 2, 3, 4])
        tensor.fill_(0)
        print(tensor.tolist())   #[0, 0, 0, 0, 0]


        #paddle.Tensor.zero_()示例：
        import paddle
        tensor = paddle.to_tensor([0, 1, 2, 3, 4])
        tensor.zero_()
        print(tensor.tolist())   #[0, 0, 0, 0, 0]

paddle-bot-old · 2021-06-29T06:29:04Z

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle/fluid/operators/fill_inplace_op.cc

python/paddle/fluid/tests/unittests/test_tensor_fill_.py

python/paddle/tensor/manipulation.py

python/paddle/tensor/__init__.py

jeff41404

lgtm

jzhang533

lgtm

paddle-bot-old · 2021-07-17T02:35:03Z

Sorry to inform you that a82597a's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

XiaoguangHu01 · 2021-07-22T01:58:50Z

python/paddle/tensor/manipulation.py

@@ -37,6 +38,78 @@
 __all__ = []


+@dygraph_only
+def fill_(x, fill_value):


这里value不需要区分，比较容易理解，建议直接用value
fill_value -> value

XiaoguangHu01 · 2021-07-22T02:01:04Z

paddle/fluid/operators/fill_inplace_op.cc

+namespace paddle {
+namespace operators {
+
+class Fill_OpMaker : public framework::OpProtoAndCheckerMaker {


这种命名方式比较奇怪，用Fill_OpMaker来区分FillOpMaker，区分度太小，
建议用FillInplaceOpMaker这种方式来区分FillOpMaker
可以确认下其他InplaceOp的写法是什么样的

done，原来的区分的方式容易跟分隔符混淆，已修改为FillInplace的命名。

XiaoguangHu01 · 2021-07-22T02:21:38Z

python/paddle/tensor/manipulation.py

+    if not (isinstance(fill_value, Variable)):
+        fill_value = paddle.to_tensor(fill_value, dtype=x.dtype)
+    assert (fill_value.size == 1), "var should be size 1"
+    return core.ops.fill_inplace_(x, fill_value)


这里已经有inplace关键字了，不需要再加下划线
fill_inplace_ -> fill_inplace

这里实现inplace版本沿用之前的方式，通过注册DECLARE_INPLACE_OP_INFERER的方式。
所以实际会生成正常和inplace两个版本，只是我们这个api只需要inplace版本，所以调用op还是需要下划线

paddle/fluid/operators/fill_any_op.cc

python/paddle/fluid/tests/unittests/test_tensor_fill_.py

paddle/fluid/operators/fill_any_op.cc

python/paddle/__init__.py

python/paddle/fluid/tests/unittests/test_fill_any_op.py

python/paddle/tensor/manipulation.py

tools/static_mode_white_list.py

python/paddle/tensor/manipulation.py

Xreki

LGTM

XiaoguangHu01

LGTM

jzhang533 · 2021-09-13T07:55:41Z

python/paddle/fluid/framework.py

-                import paddle.fluid as fluid
-                fluid.set_flags({'FLAGS_eager_delete_tensor_gb': 1.0})
+                import paddle
+                paddle.set_flags({'FLAGS_eager_delete_tensor_gb': 1.0})


可以在set_flags和get_flags的docstring里加上对
https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/guides/flags/flags_cn.html
的链接。

jzhang533 · 2021-09-13T08:01:52Z

python/paddle/tensor/manipulation.py

+
+    Args:
+        x(Tensor): ``x`` is the Tensor we want to filled data inplace
+        value(Scale): ``value`` is the value to fill in x


to be filled

jzhang533 · 2021-09-13T08:02:12Z

python/paddle/tensor/manipulation.py

+
+            import paddle
+
+            tensor = paddle.to_tensor([0,1,2,3,4])


PEP8 规范的话, 逗号后面要有空格吧。

jzhang533 · 2021-09-13T08:04:44Z

python/paddle/tensor/manipulation.py

@@ -37,6 +38,74 @@
 __all__ = []


+@dygraph_only
+def fill_(x, value):


out-place 版本我记得是paddle.full
这个为什么没用paddle.full_，而是用了paddle.fill_ ？

paddle.full底层使用op fill_constant，没有反向传播，只能作为叶子节点。torch.fill_是可以反向的，所以新增了op，这样可以跟torch对齐

jzhang533 · 2021-09-13T08:12:00Z

python/paddle/tensor/manipulation.py

+
+
+@dygraph_only
+def zero_(x):


对应的outplace版本是paddle.zeros ?

add fill_ backward

jzhang533

lgtm

XiaoguangHu01

LGTM

jeff41404

lgtm

) add fill_ backward

jeff41404 reviewed Jul 1, 2021

View reviewed changes

paddle/fluid/operators/fill_inplace_op.cc Outdated Show resolved Hide resolved

jeff41404 reviewed Jul 1, 2021

View reviewed changes

paddle/fluid/operators/fill_inplace_op.cc Outdated Show resolved Hide resolved

jeff41404 reviewed Jul 1, 2021

View reviewed changes

paddle/fluid/operators/fill_inplace_op.cc Outdated Show resolved Hide resolved

jeff41404 reviewed Jul 1, 2021

View reviewed changes

python/paddle/fluid/tests/unittests/test_tensor_fill_.py Show resolved Hide resolved

jeff41404 reviewed Jul 1, 2021

View reviewed changes

python/paddle/tensor/manipulation.py Show resolved Hide resolved

zhiboniu changed the title ~~add new inplace api Tensor.fill_ and Tensor.zero_~~ add new inplace api Tensor.fill_, Tensor.zero_ and Tensor.mul_ Jul 2, 2021

zhiboniu changed the title ~~add new inplace api Tensor.fill_, Tensor.zero_ and Tensor.mul_~~ add new inplace api Tensor.fill_, Tensor.zero_ Jul 5, 2021

jeff41404 reviewed Jul 9, 2021

View reviewed changes

python/paddle/tensor/__init__.py Outdated Show resolved Hide resolved

jeff41404 previously approved these changes Jul 9, 2021

View reviewed changes

jzhang533 previously approved these changes Jul 10, 2021

View reviewed changes

zhiboniu dismissed stale reviews from jzhang533 and jeff41404 via a0e661b July 21, 2021 06:47

XiaoguangHu01 reviewed Jul 22, 2021

View reviewed changes

Xreki reviewed Sep 1, 2021

View reviewed changes

Xreki reviewed Sep 8, 2021

View reviewed changes

Xreki previously approved these changes Sep 13, 2021

View reviewed changes

XiaoguangHu01 previously approved these changes Sep 13, 2021

View reviewed changes

jzhang533 reviewed Sep 13, 2021

View reviewed changes

add paddle.Tensor api fill_(inplace), zero_(inplace)

d945633

add fill_ backward

zhiboniu dismissed stale reviews from XiaoguangHu01 and Xreki via d945633 September 13, 2021 10:41

jzhang533 approved these changes Sep 13, 2021

View reviewed changes

XiaoguangHu01 approved these changes Sep 13, 2021

View reviewed changes

jeff41404 approved these changes Sep 14, 2021

View reviewed changes

jeff41404 merged commit efeec79 into PaddlePaddle:develop Sep 14, 2021

AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021

add paddle.Tensor api fill_(inplace), zero_(inplace) (PaddlePaddle#33829

83a2046

) add fill_ backward

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add new inplace api Tensor.fill_, Tensor.zero_ #33829

add new inplace api Tensor.fill_, Tensor.zero_ #33829

zhiboniu commented Jun 29, 2021 •

edited

Loading

paddle-bot-old bot commented Jun 29, 2021

jeff41404 left a comment

jzhang533 left a comment

paddle-bot-old bot commented Jul 17, 2021

XiaoguangHu01 Jul 22, 2021

zhiboniu Jul 22, 2021

XiaoguangHu01 Jul 22, 2021

zhiboniu Jul 22, 2021

XiaoguangHu01 Jul 22, 2021

zhiboniu Jul 22, 2021

Xreki left a comment

XiaoguangHu01 left a comment

jzhang533 Sep 13, 2021

zhiboniu Sep 13, 2021

jzhang533 Sep 13, 2021

zhiboniu Sep 13, 2021

jzhang533 Sep 13, 2021

zhiboniu Sep 13, 2021

jzhang533 Sep 13, 2021

zhiboniu Sep 13, 2021

jzhang533 Sep 13, 2021

zhiboniu Sep 13, 2021

jzhang533 left a comment

XiaoguangHu01 left a comment

jeff41404 left a comment



		@dygraph_only
		def zero_(x):

add new inplace api Tensor.fill_, Tensor.zero_ #33829

add new inplace api Tensor.fill_, Tensor.zero_ #33829

Conversation

zhiboniu commented Jun 29, 2021 • edited Loading

PR types

PR changes

Describe

paddle-bot-old bot commented Jun 29, 2021

jeff41404 left a comment

Choose a reason for hiding this comment

jzhang533 left a comment

Choose a reason for hiding this comment

paddle-bot-old bot commented Jul 17, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Xreki left a comment

Choose a reason for hiding this comment

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jzhang533 left a comment

Choose a reason for hiding this comment

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

zhiboniu commented Jun 29, 2021 •

edited

Loading