Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support finetuning the model saved on the mac platform on the Linux p… #34027

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

hbwx24
Copy link
Contributor

@hbwx24 hbwx24 commented Jul 8, 2021

PR types

Bug fixes

PR changes

OPs

Describe

image
修复《jit.save在Mac系统上保存的模型,在Linux平台上无法对模型进行重训练》的问题。

  • 原因:如上图,在mac与linux 保存的program中matmul op描述不一致,左边Linux,右边mac,linux 的matmul op 多一个 head_number =1属性。由于在Linux加载这个Program时因为找不到head_number属性而报错。

  • 可以修复的原因:在mac上保存的program没有head_number属性,在Linux上加载时,没有这个属性就默认head_number=1。

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 8, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

head_number = context.Attr<int>("head_number");
if (context.HasAttr("head_number")) {
head_number = context.Attr<int>("head_number");
}
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前matmul有两个,还是一个matmul_v2 辛苦check一下是否有同样的问题

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matmul_v2 在Linux上多两个属性:mkldnn_data_type = float32,use_mkldnn = False,在mac上保存的Program在Linux上是可以运行的

@hbwx24 hbwx24 merged commit 4d259b9 into PaddlePaddle:develop Jul 12, 2021
hbwx24 added a commit to hbwx24/Paddle that referenced this pull request Jul 14, 2021
lanxianghit pushed a commit that referenced this pull request Jul 15, 2021
…nux (#34027) (#34154)

修复《jit.save在Mac系统上保存的模型,在Linux平台上无法对模型进行重训练》的问题。

原始PR: #34027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants