-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPU-PSLIB] Add clearer error log when sparse key name is not int type, test=develop #34173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
yaoxuefeng6
reviewed
Jul 15, 2021
try { | ||
slot = boost::lexical_cast<int>(sparse_key_names[i]); | ||
} catch (boost::bad_lexical_cast const& e) { | ||
std::cout << "Error: " << e.what() << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use VLOG
yaoxuefeng6
previously approved these changes
Jul 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yaoxuefeng6
approved these changes
Jul 16, 2021
WorgenZhang
added a commit
to WorgenZhang/Paddle
that referenced
this pull request
Jul 16, 2021
WorgenZhang
added a commit
to WorgenZhang/Paddle
that referenced
this pull request
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
问题描述:
想在保存的sparse embedding中加上slot_name
关键配置:
config_fleet.py中config['dump_slot'] = True
network.py中sparse特征fluid.layers.data的name设置为非Int类型
dataset_generator.py中sparse特征的name设置为非Int类型
报错信息:
修改说明:
上面报错十分不明显,使用者完全无法根据上面报错进行排查,更无法定位到是因为开启了dump_slot,且sparse特证名不为int导致的;因此,在该报错处增加更明显的报错信息,以方便使用者定位问题
修改后报错日志: