Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trt reduce_mean supported #34204

Merged
merged 15 commits into from
Jul 21, 2021
Merged

trt reduce_mean supported #34204

merged 15 commits into from
Jul 21, 2021

Conversation

b3602sss
Copy link
Contributor

@b3602sss b3602sss commented Jul 16, 2021 •
edited
Loading

PR types

New features

PR changes

OPs

Describe

增加reduce_mean支持，修改reduce op支持静态shape.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XieYunshen
XieYunshen previously approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for set_tests_properties(test_trt_reduce_mean_op PROPERTIES TIMEOUT 60)

@b3602sss b3602sss changed the title reduce_mean supported. test=allcase trt reduce_mean supported. Jul 19, 2021
cryoco
cryoco previously approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@cryoco cryoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shangzhizhou
shangzhizhou reviewed Jul 19, 2021
View reviewed changes
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

完善测试case，比如
1、非动态shape
2、动态shape不在batch维度（第0维）的情况
3、fp16
4、开启序列化

@b3602sss b3602sss dismissed stale reviews from cryoco and XieYunshen via 840a079 July 20, 2021 07:27
shangzhizhou
shangzhizhou approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shangzhizhou shangzhizhou merged commit aff1496 into PaddlePaddle:develop Jul 21, 2021
@b3602sss b3602sss changed the title trt reduce_mean supported. trt reduce_mean supported Jul 21, 2021
@b3602sss b3602sss deleted the reduce_mean branch July 21, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XieYunshen XieYunshen XieYunshen approved these changes

@shangzhizhou shangzhizhou shangzhizhou approved these changes

@cryoco cryoco cryoco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b3602sss @cryoco @XieYunshen @shangzhizhou