[NPU] add NPU ops of compare, test=develop #34365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
|
Aganlengzi
force-pushed
the
add_compare_npu_op_dev
branch
from
4d71fb0
to
c459554
Compare
… add_compare_npu_op_dev
… add_compare_npu_op_dev
qili93
reviewed
Jul 26, 2021
| def init_dtype(self): | ||
| self.dtype = np.float16 | ||
|
|
||
|
|
There was a problem hiding this comment.
建议这里所有的单测case，参考test_compare_op.py用 create_test的方式重写一个，一个是增加代码简洁度，可以直接看到有哪几个OP的单测被cover了；另一个原因是NPU在设计单测上一个是要尽量和CPU/CUDA的单测对齐，并且单测case要>= CPU/CUDA的单测case来保证NPU算子的准确性。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Add new NPU compare ops of less_equal, greater_than, greater_equal.
