Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix optimizer.py #34431

Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix optimizer.py #34431

merged 1 commit into from
Jul 28, 2021

Conversation

sljlp
Copy link
Contributor

@sljlp sljlp commented Jul 27, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

APIs

Describe

if op type is clear_float_status,
it's device should be set self._device:all

@sljlp
fix optimizer.py
ae63a12 
if op type is cleat_float_status, then set it's device all
@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 27, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

wangxicoding
wangxicoding approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxicoding wangxicoding merged commit 0fb15d9 into PaddlePaddle:develop Jul 28, 2021
@sljlp sljlp deleted the fix_optimizer_clear_float_status branch September 5, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangxicoding wangxicoding wangxicoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sljlp @wangxicoding