-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setitem by None index #34442
Conversation
Thanks for your contribution! |
@@ -127,6 +127,8 @@ class SetValueMaker : public framework::OpProtoAndCheckerMaker { | |||
AddAttr<std::vector<int64_t>>("decrease_axes", | |||
"(list<int>) The axes to decrease.") | |||
.SetDefault({}); | |||
AddAttr<std::vector<int64_t>>("none_axes", "(list<int>) The axes to none.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看一下set_value_op下面的版本控制,新增attr要声明版本,否则可能会造成推理的兼容问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
APIs
Describe
Support setitem by None index
Example: